Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our own local copy of @glimemr/syntax when we run prettier to make sure we didn't break prettier #1683

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jan 21, 2025

it works:


❯ pnpm why @glimmer/syntax -r
Legend: production dependency, optional only, dev only

[email protected] <repo> (PRIVATE)

devDependencies:
@glimmer-workspace/integration-tests link:packages/@glimmer-workspace/integration-tests
├─┬ @glimmer/compiler link:packages/@glimmer/compiler
│ └── @glimmer/syntax link:packages/@glimmer/syntax
└── @glimmer/syntax link:packages/@glimmer/syntax

@glimmer-workspace/[email protected] <repo>/packages/@glimmer-workspace/integration-tests (PRIVATE)

dependencies:
@glimmer/compiler link:../../@glimmer/compiler
└── @glimmer/syntax link:../../@glimmer/syntax
@glimmer/syntax link:../../@glimmer/syntax

@glimmer-test/[email protected] <repo>/packages/@glimmer-workspace/integration-tests/test (PRIVATE)

dependencies:
@glimmer-workspace/integration-tests link:..
├─┬ @glimmer/compiler link:../../../@glimmer/compiler
│ └── @glimmer/syntax link:../../../@glimmer/syntax
└── @glimmer/syntax link:../../../@glimmer/syntax
@glimmer/compiler link:../../../@glimmer/compiler
└── @glimmer/syntax link:../../../@glimmer/syntax
@glimmer/syntax link:../../../@glimmer/syntax

@glimmer/[email protected] <repo>/packages/@glimmer/compiler

dependencies:
@glimmer/syntax link:../syntax

@glimmer-test/[email protected] <repo>/packages/@glimmer/compiler/test (PRIVATE)

dependencies:
@glimmer/compiler link:..
└── @glimmer/syntax link:../../syntax
@glimmer/syntax link:../../syntax

@glimmer/[email protected] <repo>/packages/@glimmer/node

devDependencies:
@glimmer/compiler link:../compiler
└── @glimmer/syntax link:../syntax

@glimmer-test/[email protected] <repo>/packages/@glimmer/syntax/test (PRIVATE)

dependencies:
@glimmer-workspace/integration-tests link:../../../@glimmer-workspace/integration-tests
├─┬ @glimmer/compiler link:../../compiler
│ └── @glimmer/syntax link:..
└── @glimmer/syntax link:..
@glimmer/syntax link:..

Copy link
Contributor

github-actions bot commented Jan 21, 2025

This PRmain
Dev
582K └─┬ .
169K   ├── runtime
159K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 27K   ├── manager
 19K   ├── validator
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner
582K └─┬ .
169K   ├── runtime
159K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 27K   ├── manager
 19K   ├── validator
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner
Prod
230K └─┬ .
 69K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
7.9K   ├── manager
4.8K   ├── program
4.0K   ├── validator
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner
230K └─┬ .
 69K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
7.9K   ├── manager
4.8K   ├── program
4.0K   ├── validator
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner

@NullVoxPopuli NullVoxPopuli merged commit f67274e into main Jan 21, 2025
9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the use-our-own-glimmer-syntax-for-prettier branch January 21, 2025 19:27
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant